Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Set default file extension for binary removal on Windows #11627

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Set default file extension for binary removal on Windows #11627

merged 1 commit into from
Mar 4, 2022

Conversation

nywilken
Copy link
Contributor

@nywilken nywilken commented Mar 4, 2022 •
edited
Loading

Related to #11625

Testing output. Next step after release is full testing for this command.

$ go run . plugins install github.com/outscale/outscale
Installed plugin github.com/outscale/outscale v1.0.2 in "C:/Users/Packer/AppData/Roaming/packer.d/plugins/github.com/outscale/outscale/packer-plugin-outscale_v1.0.2_x5.0_windows_amd64.exe"   

$ go run . plugins installed
C:\Users\Packer\AppData\Roaming\packer.d\plugins\github.com\outscale\outscale\packer-plugin-outscale_v1.0.2_x5.0_windows_amd64.exe
C:\Users\Packer\AppData\Roaming\packer.d\plugins\github.com\hashicorp\amazon\packer-plugin-amazon_v1.0.8_x5.0_windows_amd64.exe

$ go run . plugins remove github.com/hashicorp/amazon

$ go run . plugins installed
C:\Users\Packer\AppData\Roaming\packer.d\plugins\github.com\outscale\outscale\packer-plugin-outscale_v1.0.2_x5.0_windows_amd64.exe
C:\Users\Packer\AppData\Roaming\packer.d\plugins\github.com\hashicorp\amazon\packer-plugin-amazon_v1.0.8_x5.0_windows_amd64.exe

$ go run . plugins remove github.com/hashicorp/amazon
C:\Users\Packer\AppData\Roaming\packer.d\plugins\github.com\hashicorp\amazon\packer-plugin-amazon_v1.0.8_x5.0_windows_amd64.exe

$ go run . plugins installed
C:\Users\Packer\AppData\Roaming\packer.d\plugins\github.com\outscale\outscale\packer-plugin-outscale_v1.0.2_x5.0_windows_amd64.exe

@nywilken nywilken requested a review from a team as a code owner March 4, 2022 03:18
@nywilken nywilken added the command/plugins Issues related to the plugins management commands label Mar 4, 2022
sylviamoss
sylviamoss approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice catch!! 🎉

@sylviamoss sylviamoss merged commit 1c398a7 into master Mar 4, 2022
@sylviamoss sylviamoss deleted the wilken/fix-plugins_remove-windows branch March 4, 2022 09:50
@azr
Copy link
Contributor

azr commented Mar 7, 2022

Good catch !

@nywilken nywilken mentioned this pull request Mar 14, 2022
Merged
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@sylviamoss sylviamoss sylviamoss approved these changes

@JenGoldstrich JenGoldstrich Awaiting requested review from JenGoldstrich

Assignees
No one assigned
Labels
command/plugins Issues related to the plugins management commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nywilken @azr @sylviamoss